fix: let PHP handle basic auth. #2142
Merged
+17
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
Jan 25, 2026
henderkes
approved these changes
Jan 25, 2026
Contributor
henderkes
left a comment
henderkes
left a comment
There was a problem hiding this comment.
Good catch, but I wonder if this is actually the source if the crashes. I don't recall doing any basic auth.
Contributor
Author
|
It's more about freeing the request info after shutdown. That wasn't possible beforehand because PHP segfaulted when trying to free basic auth on shutdown. |
alexandre-daubois
approved these changes
Jan 26, 2026
Member
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that PHP likes to handle and free basic auth parameters internally (see here and here). This PR changes it so the basic auth header is forwarded to PHP instead of resolving it in go.
I suspect that this might fix some crashes in shutdown functions (like #2121 and #1841) since it allows us freeing the
request_infoafter shutdown is finished. I haven't been able to reproduce these crashes yet though.